[v15] player: fix seeking during dead time#40442
Merged
zmb3 merged 7 commits intobranch/v15from Apr 12, 2024
Merged
Conversation
This addresses a bug in the new player API where the player does not respond to seeking during large periods of "dead time." For example, if there is 30 seconds of dead time between two events, the player is effectively in a 30 second sleep. Attempting to change the position of playback during this 30-second period works, but is not observed until the sleep completes. With this change, the sleep period is canceled when the user seeks to a new position. Fixes #38560
Restart the stream in this case rather than trying to keep server and client state in sync.
rosstimothy
approved these changes
Apr 10, 2024
kimlisa
approved these changes
Apr 10, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #38914 to branch/v15
changelog: Improved the responsiveness of the session player during long periods of idle time.