player: fix seeking during dead time#38914
Merged
Merged
Conversation
rosstimothy
approved these changes
Mar 3, 2024
Comment on lines
288
to
290
Contributor
There was a problem hiding this comment.
Maybe update the comment to indicate that the delay can be interrupted by user operations?
Collaborator
Author
|
Looks like I have some flakiness to sort out 😞 |
This addresses a bug in the new player API where the player does not respond to seeking during large periods of "dead time." For example, if there is 30 seconds of dead time between two events, the player is effectively in a 30 second sleep. Attempting to change the position of playback during this 30-second period works, but is not observed until the sleep completes. With this change, the sleep period is canceled when the user seeks to a new position. Fixes #38560
zmb3
force-pushed
the
zmb3/player-delay-fix
branch
from
6274741 to
a1db340
Compare
Contributor
|
when testing, the idle time no longer freezes me, but trying to skip over the idle time, doesn't resume recording as it should: https://www.loom.com/share/892305a678974f00ad293310b37d787f (the video says 3 minute, i forgot so it went on longer) the timer and bar is incrementing, but the recording doesn't show me anything (and if i let it, timer and bar keeps going after the end time) |
zmb3
force-pushed
the
zmb3/player-delay-fix
branch
from
abe43c0 to
ad49605
Compare
Restart the stream in this case rather than trying to keep server and client state in sync.
zmb3
force-pushed
the
zmb3/player-delay-fix
branch
from
ad49605 to
581ba32
Compare
kimlisa
approved these changes
Apr 1, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from fheinecke
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a bug in the new player API where the player does not respond to seeking during large periods of "dead time." For example, if there is 30 seconds of dead time between two events, the player is effectively in a 30 second sleep. Attempting to change the position of playback during this 30-second period works, but is not observed until the sleep completes.
With this change, the sleep period is canceled when the user seeks to a new position.
Fixes #38560
Changelog: Improve the responsiveness of the session player during long periods of idle time.