Correctly propagate windows desktop logins in GetUnifiedResourcePage#40359
Merged
rosstimothy merged 1 commit intomasterfrom Apr 9, 2024
Merged
Correctly propagate windows desktop logins in GetUnifiedResourcePage#40359rosstimothy merged 1 commit intomasterfrom
rosstimothy merged 1 commit intomasterfrom
Conversation
The conversion from a proto.PaginatedResource to a types.EnrichedResource inadvertently omitted setting logins for windows desktops. A new test, TestGetUnifiedResourcesWithLogins, was added to validate that if logins are provided by the server that they are passed along in the enriched resource. Closes #40340
zmb3
approved these changes
Apr 9, 2024
gabrielcorado
approved these changes
Apr 9, 2024
|
@rosstimothy See the table below for backport results.
|
This was referenced Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion from a proto.PaginatedResource to a types.EnrichedResource inadvertently omitted setting logins for windows desktops. A new test, TestGetUnifiedResourcesWithLogins, was added to validate that if logins are provided by the server that they are passed along in the enriched resource.
Closes #40340
Changelog: Fixes a bug that prevented the available logins for windows desktops in leaf clusters that were being accessed via the root cluster web ui.