Include requiresRequest flag for searchAsRoles requests#40328
Conversation
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
2190190 to
ec99805
Compare
|
After fiddling with this a bit, I think instead of checking if If a new web client calls an old proxy with Also, if an old web client hits a new proxy, it won't send the new param anyway and everything will be as expected. I will update the PR with this new field and then address the current feedback (that doesn't care about the param name) |
nklaassen
left a comment
There was a problem hiding this comment.
Looks pretty good to me, I would approve but I don't see any tests for this, will you be adding some?
Yup, just added. thanks for the detailed feedback! |
There was a problem hiding this comment.
Only populated ..... ?
There was a problem hiding this comment.
add a comment to this field too?
f085fdc to
282bf78
Compare
This PR is the start of a series that will allow users to make access requests directly from the resources page in the web UI.
The purpose of this PR is to add a flag to differentiate between resources being returned due to static access, and resources returned during an "extended" auth context (for a
searchAsRoles) request.The second part of this series will be appending this
RequiresRequestvalue to all of themakeResourcemethods for the resources returned to the web UI. I decided to leave that out of this PR so the focus could be on the method I'm proposing to differentiate between the two types of access.changelog: Audit events for
AccessRequestResourceSearchare no longer emitted.