Connect: Show all recent connections in connection list#40197
Merged
Connect: Show all recent connections in connection list#40197
Conversation
gzdunek
approved these changes
Apr 4, 2024
kimlisa
approved these changes
Apr 5, 2024
|
@ravicious See the table below for backport results.
|
ravicious
added
the
no-changelog
This was referenced Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list is now scrollable instead of being capped at 10 items.
I spent way too much time on this, I've also been trying to make the search bar sticky. In the end I kept it very simple.
Having a sticky search bar is certainly possible, but I think it's not worth all the extra complexity. You have to set z-index, then each callsite that wants to use
FilterableListneeds to specify bg of the parent container in whichFilterableListis used. This is to make the search input cover other items when scrolling.Since
FilterableListis used for the cluster list, I added the scrolling behavior there as well just in case.