Conversation
kimlisa
added
no-changelog
avatus
left a comment
avatus
left a comment
There was a problem hiding this comment.
I didn't get to run it e2e yet but code looks good
| background: fade(theme.colors.link, 0.1), | ||
| border: `${theme.radii[1]}px solid ${theme.colors.link}`, | ||
| background: fade(theme.colors.accent.main, 0.1), | ||
| border: `${theme.radii[1]}px solid ${theme.colors.accent.main}`, |
There was a problem hiding this comment.
nit:
using radii as a border value could bite us in the future if we decided "lets make things more round" and then all of a sudden this border is thicker too. I think the value 2px here would be better
There was a problem hiding this comment.
what is the use case for radii then?
There was a problem hiding this comment.
It should be specific to border-radius. Also, I didn't see this before, but our theme has theme.borders so we could just do
| border: `${theme.radii[1]}px solid ${theme.colors.accent.main}`, | |
| border: `${theme.borders[2]} ${theme.colors.accent.main}`, |
|
friendly ping @rudream (i'll apply michaels change right before i merge) |
- Added splitAwsIamArn helper that splits account id and its arn parts - Require running a new script per change of each editable fields (includes roleArn) - fix test to not emit "wrap with act" warning
kimlisa
force-pushed
the
lisa/web-s3-bucket-warn
branch
from
be460e0 to
77f47a9
Compare
|
FYI, this broke |
4 participants
requires
Description:
listing:
listing, after clicking on button:
editing:
creating:
changelog: Amazon S3 fields are now optional when creating or editing AWS OIDC integration on the web UI