AWS OIDC set up: S3 is optional#39912
Merged
marcoandredinis merged 2 commits intomasterfrom Apr 3, 2024
Merged
Conversation
marcoandredinis
added
aws
Contributor
|
This will also affect TAG |
marcoandredinis
force-pushed
the
marco/awsoidc-s3-optional
branch
from
d12d347 to
c58ca42
Compare
kimlisa
approved these changes
Apr 2, 2024
marcoandredinis
force-pushed
the
marco/awsoidc-s3-optional
branch
from
c58ca42 to
287e02f
Compare
espadolini
approved these changes
Apr 3, 2024
Comment on lines
879
to
881
Contributor
There was a problem hiding this comment.
We always serve the oidc configuration from the proxy even if the S3 bucket is enabled, right? This comment kinda makes it seem like it's only one of the two at a time.
public-teleport-github-review-bot
Bot
removed the request for review
from atburke
marcoandredinis
force-pushed
the
marco/awsoidc-s3-optional
branch
from
287e02f to
64ef29c
Compare
|
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
Apr 3, 2024
* AWS OIDC set up: support set up that doesnt use S3 location * be explicit about always having the public keys being served at the proxy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using an S3 bucket is optional.
Some users don't want to/can't use the S3 bucket.
Context: #39901