Skip to content

[v15] Fix opsgenie plugin to use correct annotation to determine whether or not to create alerts #40121

Merged
EdwardDowling merged 17 commits intobranch/v15from
edwarddowling/backport-38435/v15
Apr 15, 2024
Merged

[v15] Fix opsgenie plugin to use correct annotation to determine whether or not to create alerts #40121
EdwardDowling merged 17 commits intobranch/v15from
edwarddowling/backport-38435/v15

Conversation

@EdwardDowling
Copy link
Copy Markdown
Contributor

@EdwardDowling EdwardDowling commented Apr 2, 2024

backport of #38435

Tested with the backwards compatible version of the behaviors for the annotations

  • notify-schedules and approval-schedules set - alert is created and approved based on the correct annotation
  • just notify-schedules set - alert is created but no auto approval flow
  • just approval-schedules - alert is created and auto approval is attempted based on just the approval schedules value

Wont change auto approval behavior until 3823 is merged to /e after this is merged

changelog: Updated Opsgenie annotations so approve-schedules is used for both alert creation and auto approval if notify schedules is not set.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2024

🤖 Vercel preview here: https://docs-dief57u5o-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling marked this pull request as ready for review April 3, 2024 14:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions github-actions Bot requested review from hugoShaka, r0mant and zmb3 April 3, 2024 14:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2024

🤖 Vercel preview here: https://docs-h3xhga9h6-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2024

🤖 Vercel preview here: https://docs-lptqduvyp-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2024

🤖 Vercel preview here: https://docs-6z3b310r5-goteleport.vercel.app/docs/ver/preview

Comment thread integrations/access/accessrequest/app.go Outdated
@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-hwbj8oywo-goteleport.vercel.app/docs/ver/preview

And add tests for accessrequest app
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-gct8pt17y-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-ouw657eke-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-df4bgzm7m-goteleport.vercel.app/docs/ver/preview

@EdwardDowling
Copy link
Copy Markdown
Contributor Author

@zmb3 can you take a look at this when you get a chance

Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming you fix the lint failures.

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from r0mant April 13, 2024 22:22
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-889gznw2k-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-dmv66d28i-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-5oigu2ioh-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling enabled auto-merge April 15, 2024 16:29
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-m3ifnblhc-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling added this pull request to the merge queue Apr 15, 2024
Merged via the queue into branch/v15 with commit e038bf1 Apr 15, 2024
@EdwardDowling EdwardDowling deleted the edwarddowling/backport-38435/v15 branch April 15, 2024 17:36
@camscale camscale mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants