Skip to content

Fix opsgenie plugin to use correct annotation to determine whether or not to create alerts#38435

Merged
EdwardDowling merged 27 commits intomasterfrom
edwarddowling/opsgenie-plugin-fix
Mar 27, 2024
Merged

Fix opsgenie plugin to use correct annotation to determine whether or not to create alerts#38435
EdwardDowling merged 27 commits intomasterfrom
edwarddowling/opsgenie-plugin-fix

Conversation

@EdwardDowling
Copy link
Copy Markdown
Contributor

@EdwardDowling EdwardDowling commented Feb 20, 2024 •
edited
Loading

Fixes Opsgenie annotation implementation and docs differing.

changelog: Breaking change for Opsgenie plugin users, role annotations must now contain "teleport.dev/notify-services" to receive notification on Opsgenie. "teleport.dev/schedules" is now the label used to determine auto approval flow

Verified that when

  • notify label and not approval label is set - alert is created
  • both set - alert is created and if the user is on call the alert is approved
  • just approval label - no alert created
  • both set and user is not on-all - alert is created but not approved

Will need 3774 merged after this to correctly instantiate the opsgneie app

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 20, 2024

🤖 Vercel preview here: https://docs-dgidxqb1w-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling force-pushed the edwarddowling/opsgenie-plugin-fix branch from 47c7c3c to c37e82b Compare March 11, 2024 18:07
@EdwardDowling EdwardDowling marked this pull request as ready for review March 11, 2024 18:11
@github-actions github-actions Bot added documentation rfd Request for Discussion size/sm labels Mar 11, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 11, 2024

🤖 Vercel preview here: https://docs-41l5bg5jl-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling changed the title Edwarddowling/opsgenie plugin fix Fix opsgenie plugin to use correct annotation to determine whether or not to create alerts Mar 11, 2024
zmb3
zmb3 previously requested changes Mar 11, 2024
View reviewed changes
Comment thread docs/img/enterprise/plugins/opsgenie/add-requester-role.png Outdated
Comment thread docs/pages/access-controls/access-request-plugins/opsgenie.mdx
Comment thread integrations/access/accessrequest/app.go
Comment thread integrations/access/opsgenie/bot.go Outdated
@ptgott
Copy link
Copy Markdown
Contributor

ptgott commented Mar 12, 2024

@EdwardDowling I'm going to unsubscribe until we sort out the technical review. Let me know if you'd like a docs review!

r0mant
r0mant requested changes Mar 13, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to Zac's comments, I don't think this is implemented in the way we discussed.

Comment thread integrations/access/accessrequest/app.go Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 13, 2024

🤖 Vercel preview here: https://docs-gnxva2gjx-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 26, 2024

🤖 Vercel preview here: https://docs-91hisuz7o-goteleport.vercel.app/docs/ver/preview

@r0mant r0mant dismissed zmb3’s stale review March 26, 2024 18:00

The issue was addressed.

@EdwardDowling EdwardDowling enabled auto-merge March 27, 2024 11:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 27, 2024

🤖 Vercel preview here: https://docs-avh24zi5i-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 27, 2024

🤖 Vercel preview here: https://docs-fxkxuhdh7-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 27, 2024

🤖 Vercel preview here: https://docs-lru5emoib-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 27, 2024

🤖 Vercel preview here: https://docs-8j9z5583u-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling added this pull request to the merge queue Mar 27, 2024
Merged via the queue into master with commit 0b01cf5 Mar 27, 2024
@EdwardDowling EdwardDowling deleted the edwarddowling/opsgenie-plugin-fix branch March 27, 2024 14:01
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Mar 27, 2024

@EdwardDowling See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Failed

@EdwardDowling EdwardDowling mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r0mant r0mant r0mant approved these changes

@hugoShaka hugoShaka hugoShaka approved these changes

@zmb3 zmb3 Awaiting requested review from zmb3

Assignees

No one assigned

Labels

documentation rfd Request for Discussion size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@EdwardDowling @ptgott @hugoShaka @r0mant @zmb3