[v15] Replace UnixShellQuote with shsprintf.EscapeDefaultContext from github.com/google/safetext#40060
Merged
jentfoo merged 1 commit intobranch/v15from Apr 1, 2024
Conversation
…hub.com/google/safetext (#40046) This change is a change in how we are handling the untrusted input. Instead of adopting a strategy of quoting (which was incomplete), this instead escapes any special characters. Although github.com/google/safetext is new, and without any current tags for us to reference, I believe it would be better to reference their implementation than to update the UnixShellQuote to handle the newly identified cases.
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
jentfoo
added
the
no-changelog
marcoandredinis
approved these changes
Mar 29, 2024
Collaborator
|
Have we tested setting up an AWS OIDC integration against a real AWS account with these changes just to make sure everything still works? |
rosstimothy
approved these changes
Mar 29, 2024
Contributor
Author
|
Join testing was only local. I used the original test cases to confirm that this produces shell compatible parameters (escaped). I also used a variety of command injection techniques to confirm that this seems to be sufficient in all our currently known cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v15 backport of #40046