Conversation
jentfoo
requested review from
codingllama,
espadolini,
marcoandredinis,
rosstimothy and
zmb3
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
rosstimothy
approved these changes
Mar 29, 2024
jentfoo
added
the
no-changelog
…hub.com/google/safetext This change is a change in how we are handling the untrusted input. Instead of adopting a strategy of quoting (which was incomplete), this instead escapes any special characters. Although github.com/google/safetext is new, and without any current tags for us to reference, I believe it would be better to reference their implementation than to update the UnixShellQuote to handle the newly identified cases.
jentfoo
force-pushed
the
jent/UnixShellQuote-replacement
branch
from
7f07d27 to
4f636ac
Compare
public-teleport-github-review-bot
Bot
removed request for
codingllama,
espadolini,
jimbishopp and
marcoandredinis
jentfoo
added a commit
that referenced
this pull request
Mar 29, 2024
…hub.com/google/safetext (#40046) This change is a change in how we are handling the untrusted input. Instead of adopting a strategy of quoting (which was incomplete), this instead escapes any special characters. Although github.com/google/safetext is new, and without any current tags for us to reference, I believe it would be better to reference their implementation than to update the UnixShellQuote to handle the newly identified cases.
jentfoo
added a commit
that referenced
this pull request
Mar 29, 2024
…hub.com/google/safetext (#40046) This change is a change in how we are handling the untrusted input. Instead of adopting a strategy of quoting (which was incomplete), this instead escapes any special characters. Although github.com/google/safetext is new, and without any current tags for us to reference, I believe it would be better to reference their implementation than to update the UnixShellQuote to handle the newly identified cases.
jentfoo
added a commit
that referenced
this pull request
Mar 29, 2024
…hub.com/google/safetext (#40046) This change is a change in how we are handling the untrusted input. Instead of adopting a strategy of quoting (which was incomplete), this instead escapes any special characters. Although github.com/google/safetext is new, and without any current tags for us to reference, I believe it would be better to reference their implementation than to update the UnixShellQuote to handle the newly identified cases.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 1, 2024
…hub.com/google/safetext (#40046) (#40060) This change is a change in how we are handling the untrusted input. Instead of adopting a strategy of quoting (which was incomplete), this instead escapes any special characters. Although github.com/google/safetext is new, and without any current tags for us to reference, I believe it would be better to reference their implementation than to update the UnixShellQuote to handle the newly identified cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #39644 where
UnixShellQuotewas introduced.This is a change in how we are handling the untrusted input. Instead of adopting a strategy of quoting (which was discovered to be incomplete), this instead escapes any special characters.
Although github.com/google/safetext is new, and without any current tags for us to reference, I believe it would be better to reference their implementation than to update the
UnixShellQuoteto handle the newly identified cases.