Fix admin MFA flow for tctl bots add#39220
Merged
Conversation
…equest fails due to a reusable MFA response being denied by the server.
rosstimothy
approved these changes
Mar 12, 2024
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
capnspacehook
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #38479 was introduced,
tctl bots add --token=<token>would fail due to a reusable MFA challenge being used in the request. This PR fixes this by:Changelog: Fix a bug that caused some MFA for Admin Action flows to fail instead of retrying: ex:
tctl bots add --token=<token>.