Require admin MFA for get/list tokens#38479
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: The changelog entry must not contain a Markdown link or image. |
rosstimothy
approved these changes
Feb 21, 2024
jentfoo
approved these changes
Feb 21, 2024
probakowski
approved these changes
Feb 26, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from EdwardDowling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: When teleport is configured to require MFA for admin actions, MFA is required to get or list tokens with
tctl. Ex:tctl tokens lsortctl get tokens/foo.Note: this also impact
tctl edit tokens. With this PR, MFA will be prompted before and after the edit. The first prompt is to retrieve the secret, and the second is to update.