Skip to content

update SAML service provider preset constant gcp to gcp-workforce #39151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flyinghermit merged 1 commit into from
Mar 12, 2024
Merged

update SAML service provider preset constant gcp to gcp-workforce #39151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/types/saml_idp_service_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ func (am *SAMLAttributeMapping) CheckAndSetDefaults() error {
// preset can be either empty or one of the supported type.
func validatePreset(preset string) bool {
switch preset {
case "", samlsp.GCP:
case "", samlsp.GCPWorkforce:
return true
default:
return false
Expand Down
2 changes: 1 addition & 1 deletion api/types/saml_idp_service_provider_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func TestNewSAMLIdPServiceProvider(t *testing.T) {
acsURL: "https:/test.com/acs",
expectedEntityID: "IAMShowcase",
errAssertion: require.NoError,
preset: samlsp.GCP,
preset: samlsp.GCPWorkforce,
},
{
name: "unsupported preset value",
Expand Down
5 changes: 3 additions & 2 deletions api/types/samlsp/samlsp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ limitations under the License.
package samlsp

const (
// GCP is a SAML service provider preset name for Google Cloud.
GCP = "gcp"
// GCPWorkforce is a SAML service provider preset name for Google Cloud Platform
// Workforce Identity Federation.
GCPWorkforce = "gcp-workforce"
)