update SAML service provider preset constant gcp to gcp-workforce#39151
Merged
flyinghermit merged 1 commit intomasterfrom Mar 12, 2024
Merged
update SAML service provider preset constant gcp to gcp-workforce#39151flyinghermit merged 1 commit intomasterfrom
gcp to gcp-workforce#39151flyinghermit merged 1 commit intomasterfrom
Conversation
flyinghermit
added
the
no-changelog
Contributor
Author
|
The constant value is not yet available in the release branches |
zmb3
approved these changes
Mar 9, 2024
Contributor
Author
|
Friendly ping @Joerger |
Joerger
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just updates the preset name
gcptogcp-workforce.gcpwas added to refer to Workforce identity federation based configuration. But a plan is underway where we may manage GCP policy with Workload Identity based integration.While the feature isn't released yet, it's right time to update the name and so to avoid confusion in the future. The names such as
gcp-workforce,gcp-workloadare more meaningful than plaingcp.