Skip to content

Update ExecReload in all Teleport systemd unit files#39070

Merged
espadolini merged 2 commits intomasterfrom
espadolini/execreload-2
Mar 7, 2024
Merged

Update ExecReload in all Teleport systemd unit files#39070
espadolini merged 2 commits intomasterfrom
espadolini/execreload-2

Conversation

@espadolini
Copy link
Copy Markdown
Contributor

@espadolini espadolini commented Mar 7, 2024

As a followup to #39028, this PR updates the ExecReload directive to use an absolute path to /bin/sh in all Teleport systemd unit files.

Fixes #39001

@espadolini espadolini added the no-changelog Indicates that a PR does not require a changelog entry label Mar 7, 2024
@github-actions github-actions Bot requested review from AntonAM and hugoShaka March 7, 2024 15:32
@hugoShaka
Copy link
Copy Markdown
Contributor

Could we drop a comment there explaining this is a gotcha? In a couple years, someone editing the system unit will forget about this and simplify the ExecReload command, causing the issue again.

@espadolini espadolini changed the title Update ExecReload in all Teleport systemd unit files Update ExecReload in all Teleport systemd unit files Mar 7, 2024
@espadolini espadolini enabled auto-merge March 7, 2024 16:07
@espadolini espadolini added this pull request to the merge queue Mar 7, 2024
Merged via the queue into master with commit 86e07c8 Mar 7, 2024
@espadolini espadolini deleted the espadolini/execreload-2 branch March 7, 2024 16:40
@public-teleport-github-review-bot
Copy link
Copy Markdown

@espadolini See the table below for backport results.

Branch Result
branch/v15 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to restart Teleport agent

3 participants