Use an absolute path in ExecReload in teleport.service#39028
Merged
espadolini merged 1 commit intomasterfrom Mar 6, 2024
Merged
Use an absolute path in ExecReload in teleport.service#39028espadolini merged 1 commit intomasterfrom
ExecReload in teleport.service#39028espadolini merged 1 commit intomasterfrom
Conversation
rosstimothy
approved these changes
Mar 6, 2024
AntonAM
approved these changes
Mar 6, 2024
public-teleport-github-review-bot
Bot
removed request for
EdwardDowling and
nklaassen
|
@espadolini See the table below for backport results.
|
This was referenced Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #37773, we changed the
ExecReloadin the systemd service file to usepkill, but while doing so, we ended up making it a relative path, which is only valid for systemd 239+, while Ubuntu 18.04 uses systemd 237 and CentOS 7 uses systemd 219.This PR changes
ExecReloadto use/bin/sh(absolute path) to launchpkill.Fixes #39001
changelog: fix compatibility of the Teleport service file with older versions of systemd