[v15] Cache remote clients in Connect#39012
Merged
gzdunek merged 5 commits intobranch/v15from Mar 7, 2024
Merged
Conversation
* Add remote client cache * Add an integration test * Close all clients when stopping the service * Move RemoteClientCache to the place where it is used * Do not check client cert in `Get` * Fix code style issues * Prevent potential race condition when removing a cached client * Test concurrent calls to `Get` * Add TODO * `remoteclientcache` -> `clientcache` * Reduce the `err` scope * Move `Config` closer to `New` and docs * Fix lint * Improve logging and error handling * Add missing comments * `Close` -> `Clear` * Improve the test * Remove mentions about "remote" client * Pass `cfg` directly to `Cache` * `InvalidateForRootCluster` -> `ClearForRootCluster` * Add docs for the interface * `ClearForRootCluster` -> `ClearForRoot` * Add config validation * Log multiple fields at once * Improve setting logger * Use cached remote clients in Connect (#38202) * Replace all simple `c.clusterClient.ConnectToProxy()` calls * Use cached proxy client to create gateways * Use cached proxy client to assume roles * Invalidate clients when logging in and out * Gracefully handle expired cert error returned by the server * Drop `GetRootClusterURI` in headless auth watcher since URIs are already root URIs * Simplify error check * Make `auth.ClientI` parameter naming more consistent, use `root` prefix when needed * Reduce error scope where possible * Clear cached clients before passwordless login * Use `fakeClientCache` without pointers * Move separate `proxyClient` parameter to `CreateGatewayParams` in the gateways code * Replace checking error string with `client.ErrClientCredentialsHaveExpired` (cherry picked from commit 39f9951)
(cherry picked from commit 7067a88)
ravicious
approved these changes
Mar 6, 2024
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
Let's not sell ourselves short, the changelog can say "Significantly reduced latency of network calls in Teleport Connect" for sure. ;)
Also, I think all PRs related to caching could be included in a single backport, couldn't they?
Contributor
Author
Done! :D
All PRs are already included, #38202 has been merged into #38201 before merging to master. Or you mean #38955? |
espadolini
approved these changes
Mar 6, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from rosstimothy
rosstimothy
approved these changes
Mar 6, 2024
* Make calls to the auth server concurrently * Enhance the comment about preferences upsert * Summarize how `userpreferences.Update` works (cherry picked from commit ddc45a4)
Contributor
Author
|
Added #38955. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #38201 to branch/v15
Changelog: Significantly reduced latency of network calls in Teleport Connect.