Temporarily disable flaky part of TestClientCache#38798
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
gzdunek
added
the
no-changelog
espadolini
approved these changes
Feb 29, 2024
rosstimothy
reviewed
Feb 29, 2024
Comment on lines
+419
to
+421
| //fourthCallForClient, err := daemonService.GetCachedClient(ctx, cluster.URI) | ||
| //require.NoError(t, err) | ||
| //require.NotEqual(t, thirdCallForClient, fourthCallForClient) |
Contributor
There was a problem hiding this comment.
Would a require.EventuallyWithT allow us to assert that things eventually got to the desired state?
Contributor
Author
There was a problem hiding this comment.
Now it fails every time, it's weird
require.EventuallyWithT(t, func(t *assert.CollectT) {
fourthCallForClient, err := daemonService.GetCachedClient(ctx, cluster.URI)
assert.NoError(t, err)
assert.NotEqual(t, thirdCallForClient, fourthCallForClient)
}, time.Second*2, time.Millisecond*100) Error: Condition never satisfied
zmb3
approved these changes
Feb 29, 2024
gzdunek
added a commit
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 7067a88)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Cache remote clients in Connect (#38201) * Add remote client cache * Add an integration test * Close all clients when stopping the service * Move RemoteClientCache to the place where it is used * Do not check client cert in `Get` * Fix code style issues * Prevent potential race condition when removing a cached client * Test concurrent calls to `Get` * Add TODO * `remoteclientcache` -> `clientcache` * Reduce the `err` scope * Move `Config` closer to `New` and docs * Fix lint * Improve logging and error handling * Add missing comments * `Close` -> `Clear` * Improve the test * Remove mentions about "remote" client * Pass `cfg` directly to `Cache` * `InvalidateForRootCluster` -> `ClearForRootCluster` * Add docs for the interface * `ClearForRootCluster` -> `ClearForRoot` * Add config validation * Log multiple fields at once * Improve setting logger * Use cached remote clients in Connect (#38202) * Replace all simple `c.clusterClient.ConnectToProxy()` calls * Use cached proxy client to create gateways * Use cached proxy client to assume roles * Invalidate clients when logging in and out * Gracefully handle expired cert error returned by the server * Drop `GetRootClusterURI` in headless auth watcher since URIs are already root URIs * Simplify error check * Make `auth.ClientI` parameter naming more consistent, use `root` prefix when needed * Reduce error scope where possible * Clear cached clients before passwordless login * Use `fakeClientCache` without pointers * Move separate `proxyClient` parameter to `CreateGatewayParams` in the gateways code * Replace checking error string with `client.ErrClientCredentialsHaveExpired` (cherry picked from commit 39f9951) * Temporarily disable flaky part of `TestClientCache` (#38798) (cherry picked from commit 7067a88) * Make calls to the auth server concurrently (#38955) * Make calls to the auth server concurrently * Enhance the comment about preferences upsert * Summarize how `userpreferences.Update` works (cherry picked from commit ddc45a4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary workaround for #38778
Unfortunately, I think the underlying problem is not that easy to solve (and I have tomorrow off). I wouldn't like to block other PRs.