[v15] Fix hostname resolution for connections in leaf clusters#38469
Merged
rosstimothy merged 1 commit intobranch/v15from Feb 27, 2024
Merged
[v15] Fix hostname resolution for connections in leaf clusters#38469rosstimothy merged 1 commit intobranch/v15from
rosstimothy merged 1 commit intobranch/v15from
Conversation
The changes to hostname resolution introduced in #35773 were always using the root cache to lookup a matching node, which is never going to find a match if the target is in the leaf cluster. This is now resolved by using the `services.NodeWatcher` of the cluster that the target node is a member of.
smallinsky
approved these changes
Feb 21, 2024
Contributor
Author
|
Ping @zmb3 |
zmb3
approved these changes
Feb 27, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #38358 to branch/v15
changelog: Fixes an issue that prevented the Web UI from properly displaying the hostname of servers in leaf clusters.