Fix hostname resolution for connections in leaf clusters#38358
Merged
rosstimothy merged 1 commit intomasterfrom Feb 20, 2024
Merged
Fix hostname resolution for connections in leaf clusters#38358rosstimothy merged 1 commit intomasterfrom
rosstimothy merged 1 commit intomasterfrom
Conversation
The changes to hostname resolution introduced in #35773 were always using the root cache to lookup a matching node, which is never going to find a match if the target is in the leaf cluster. This is now resolved by using the `services.NodeWatcher` of the cluster that the target node is a member of.
rosstimothy
force-pushed
the
tross/leaf_hostname
branch
from
4af6fea to
cc0aa8f
Compare
zmb3
approved these changes
Feb 16, 2024
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
Looks good but can we add a test since this was a regression?
smallinsky
approved these changes
Feb 19, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from tcsc
Contributor
Author
I would very much like to add a test, however, the way "Teleport" is setup and created in the |
|
@rosstimothy See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes to hostname resolution introduced in #35773 were always using the root cache to lookup a matching node, which is never going to find a match if the target is in the leaf cluster. This is now resolved by using the
services.NodeWatcherof the cluster that the target node is a member of.Changelog: Fixes an issue that prevented the Web UI from properly displaying the hostname of servers in leaf clusters.