[v12] fix key generation for dual auths sharing a single YubiHSM2#37305
Merged
nklaassen merged 1 commit intobranch/v12from Jan 29, 2024
Merged
[v12] fix key generation for dual auths sharing a single YubiHSM2#37305nklaassen merged 1 commit intobranch/v12from
nklaassen merged 1 commit intobranch/v12from
Conversation
Backport #36899 to branch/v12 The actual fix is a few characters in lib/auth/keystore/pkcs11.go. I'm also backporting changes to test files from #36549 that this PR built on top of, which make it easier to run all HSM unit and integration tests with a connected YubiHSM2 (which I did when putting together this backport). Instead of merging all changes in the integration tests, I just checked out the state of them from branch/v13 in #37301 Changelog: fixes CA key generation when two auth servers share a single YubiHSM2
zmb3
approved these changes
Jan 26, 2024
hugoShaka
approved these changes
Jan 29, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36899 to branch/v12
The actual fix is a few characters in lib/auth/keystore/pkcs11.go. I'm also backporting changes to test files from #36549 that this PR built on top of, which make it easier to run all HSM unit and integration tests with a connected YubiHSM2 (which I did when putting together this backport).
Instead of merging all changes in the integration tests, I just checked out the state of them from branch/v13 in
#37301
Changelog: Fixed CA key generation when two auth servers share a single YubiHSM2