Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions api/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -4181,10 +4181,8 @@ func (c *Client) DeleteAllIntegrations(ctx context.Context) error {
}

// GenerateAWSOIDCToken generates a token to be used when executing an AWS OIDC Integration action.
func (c *Client) GenerateAWSOIDCToken(ctx context.Context, req types.GenerateAWSOIDCTokenRequest) (string, error) {
resp, err := c.integrationsClient().GenerateAWSOIDCToken(ctx, &integrationpb.GenerateAWSOIDCTokenRequest{
Issuer: req.Issuer,
})
func (c *Client) GenerateAWSOIDCToken(ctx context.Context) (string, error) {
resp, err := c.integrationsClient().GenerateAWSOIDCToken(ctx, &integrationpb.GenerateAWSOIDCTokenRequest{})
if err != nil {
return "", trace.Wrap(err)
}
Expand Down
115 changes: 60 additions & 55 deletions api/gen/proto/go/teleport/integration/v1/integration_service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion api/proto/teleport/integration/v1/integration_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ message DeleteAllIntegrationsRequest {}
message GenerateAWSOIDCTokenRequest {
// Issuer is the entity that is signing the JWT.
// This value must contain the AWS OIDC Integration configured provider (Teleport Proxy's Public URL)
string issuer = 1;
//
// Deprecated: Ignored because value is calculated server side.
string issuer = 1 [deprecated = true];
}

// GenerateAWSOIDCTokenResponse contains a signed AWS OIDC Integration token.
Expand Down
18 changes: 0 additions & 18 deletions api/types/integration_awsoidc.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ limitations under the License.

package types

import "github.com/gravitational/trace"

const (
// IntegrationAWSOIDCAudience is the client id used to generate the JWT.
// This value must match the Audience defined in the IAM Identity Provider of the Integration.
Expand All @@ -30,19 +28,3 @@ const (
// token as the Teleport Auth service.
IntegrationAWSOIDCSubjectAuth = "system:auth"
)

// GenerateAWSOIDCTokenRequest are the parameters used to request an AWS OIDC Integration token.
type GenerateAWSOIDCTokenRequest struct {
// Issuer is the entity that is signing the JWT.
// This value must contain the AWS OIDC Integration configured provider (Proxy's Public URL).
Issuer string `json:"issuer"`
}

// CheckAndSetDefaults checks if the required fields are present.
func (req *GenerateAWSOIDCTokenRequest) CheckAndSetDefaults() error {
if req.Issuer == "" {
return trace.BadParameter("issuer is required")
}

return nil
}
42 changes: 0 additions & 42 deletions api/types/integration_awsoidc_test.go

This file was deleted.

6 changes: 3 additions & 3 deletions lib/auth/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ type DiscoveryAccessPoint interface {
SubmitUsageEvent(ctx context.Context, req *proto.SubmitUsageEventRequest) error

// GenerateAWSOIDCToken generates a token to be used to execute an AWS OIDC Integration action.
GenerateAWSOIDCToken(ctx context.Context, req types.GenerateAWSOIDCTokenRequest) (string, error)
GenerateAWSOIDCToken(ctx context.Context) (string, error)
}

// ReadOktaAccessPoint is a read only API interface to be
Expand Down Expand Up @@ -1312,8 +1312,8 @@ func (w *DiscoveryWrapper) SubmitUsageEvent(ctx context.Context, req *proto.Subm
}

// GenerateAWSOIDCToken generates a token to be used to execute an AWS OIDC Integration action.
func (w *DiscoveryWrapper) GenerateAWSOIDCToken(ctx context.Context, req types.GenerateAWSOIDCTokenRequest) (string, error) {
return w.NoCache.GenerateAWSOIDCToken(ctx, req)
func (w *DiscoveryWrapper) GenerateAWSOIDCToken(ctx context.Context) (string, error) {
return w.NoCache.GenerateAWSOIDCToken(ctx)
}

// Close closes all associated resources
Expand Down
4 changes: 2 additions & 2 deletions lib/auth/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -545,8 +545,8 @@ func (r *Services) GetWebToken(ctx context.Context, req types.GetWebTokenRequest
}

// GenerateAWSOIDCToken generates a token to be used to execute an AWS OIDC Integration action.
func (r *Services) GenerateAWSOIDCToken(ctx context.Context, req types.GenerateAWSOIDCTokenRequest) (string, error) {
return r.IntegrationsTokenGenerator.GenerateAWSOIDCToken(ctx, req)
func (r *Services) GenerateAWSOIDCToken(ctx context.Context) (string, error) {
return r.IntegrationsTokenGenerator.GenerateAWSOIDCToken(ctx)
}

// OktaClient returns the okta client.
Expand Down
12 changes: 3 additions & 9 deletions lib/auth/auth_with_roles.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ func (a *ServerWithRoles) integrationsService() (*integrationv1.Service, error)
Authorizer: authz.AuthorizerFunc(func(context.Context) (*authz.Context, error) {
return &a.context, nil
}),
Cache: a.authServer.Cache,
Cache: a.authServer,
Backend: a.authServer.Services,
})
if err != nil {
Expand Down Expand Up @@ -388,19 +388,13 @@ func (a *ServerWithRoles) DeleteIntegration(ctx context.Context, name string) er
}

// GenerateAWSOIDCToken generates a token to be used when executing an AWS OIDC Integration action.
func (a *ServerWithRoles) GenerateAWSOIDCToken(ctx context.Context, req types.GenerateAWSOIDCTokenRequest) (string, error) {
func (a *ServerWithRoles) GenerateAWSOIDCToken(ctx context.Context) (string, error) {
igSvc, err := a.integrationsService()
if err != nil {
return "", trace.Wrap(err)
}

if err := req.CheckAndSetDefaults(); err != nil {
return "", trace.Wrap(err)
}

resp, err := igSvc.GenerateAWSOIDCToken(ctx, &integrationpb.GenerateAWSOIDCTokenRequest{
Issuer: req.Issuer,
})
resp, err := igSvc.GenerateAWSOIDCToken(ctx, &integrationpb.GenerateAWSOIDCTokenRequest{})
if err != nil {
return "", trace.Wrap(err)
}
Expand Down
2 changes: 1 addition & 1 deletion lib/auth/clt.go
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ type ClientI interface {
GetWebToken(ctx context.Context, req types.GetWebTokenRequest) (types.WebToken, error)

// GenerateAWSOIDCToken generates a token to be used to execute an AWS OIDC Integration action.
GenerateAWSOIDCToken(ctx context.Context, req types.GenerateAWSOIDCTokenRequest) (string, error)
GenerateAWSOIDCToken(ctx context.Context) (string, error)

// ResetAuthPreference resets cluster auth preference to defaults.
ResetAuthPreference(ctx context.Context) error
Expand Down
10 changes: 5 additions & 5 deletions lib/auth/grpcserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -5735,11 +5735,11 @@ func NewGRPCServer(cfg GRPCServerConfig) (*GRPCServer, error) {
oktapb.RegisterOktaServiceServer(server, oktaServiceServer)

integrationServiceServer, err := integrationService.NewService(&integrationService.ServiceConfig{
Authorizer: cfg.Authorizer,
Backend: cfg.AuthServer.Services,
Cache: cfg.AuthServer.Cache,
Clock: cfg.AuthServer.clock,
CAGetter: cfg.AuthServer,
Authorizer: cfg.Authorizer,
Backend: cfg.AuthServer.Services,
Cache: cfg.AuthServer.Cache,
KeyStoreManager: cfg.AuthServer.GetKeyStore(),
Clock: cfg.AuthServer.clock,
})
if err != nil {
return nil, trace.Wrap(err)
Expand Down
Loading