AWSOIDC: Compute Proxy's Endpoint for issuing a token#37253
Merged
marcoandredinis merged 3 commits intomasterfrom Jan 26, 2024
Merged
AWSOIDC: Compute Proxy's Endpoint for issuing a token#37253marcoandredinis merged 3 commits intomasterfrom
marcoandredinis merged 3 commits intomasterfrom
Conversation
marcoandredinis
added
discover
Closed
Instead of receiving the issuer URL as param, use the internal state of the proxies to fetch the public endpoint. This deprecates the field so that old clients can still talk to the AuthServer, but their Issuer param is ignored.
marcoandredinis
force-pushed
the
marco/awsoidc-token-issuer-auth
branch
from
4b203bd to
489a4be
Compare
rosstimothy
reviewed
Jan 25, 2024
gzdunek
approved these changes
Jan 26, 2024
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
I'm leaving the approval, but I'm not familiar with this part of the codebase.
|
@marcoandredinis See the table below for backport results.
|
This was referenced Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of receiving the issuer URL as param, use the internal state of the proxies to fetch the public endpoint.
This deprecates the field so that old clients can still talk to the AuthServer, but their Issuer param is ignored.
Related: #37245
changelog: AWSOIDC Token Generation API no longer accepts the issuer.