Remove unused admin action name from IsMFARequiredRequest_AdminAction#37102
Merged
Remove unused admin action name from IsMFARequiredRequest_AdminAction#37102
IsMFARequiredRequest_AdminAction#37102Conversation
Joerger
added
no-changelog
rosstimothy
reviewed
Jan 23, 2024
codingllama
reviewed
Jan 23, 2024
codingllama
approved these changes
Jan 24, 2024
ryanclark
approved these changes
Jan 24, 2024
public-teleport-github-review-bot
Bot
removed request for
EdwardDowling and
smallinsky
Joerger
force-pushed
the
joerger/update-admin-action-mfa-check
branch
from
f409355 to
3378e6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #36785, I added the admin action name field to the
IsMFARequiredRequestin case it could be useful, but ended up not using it or developing any plans to use it. Additionally, in the reused MFA case it is unclear which/what admin action name to use.Since it is unused and just dead code, we should remove it before it makes it into a release. If we find a use for it we can add it later.