Extend IsMFARequired check to admin actions#36785
Merged
Conversation
Joerger
added
the
no-changelog
gzdunek
reviewed
Jan 17, 2024
Contributor
There was a problem hiding this comment.
From what I see, we usually use camel case for json fields.
Contributor
Author
There was a problem hiding this comment.
It looks pretty split actually. snake_case seems to be slightly more common in our code and is more conventional for json fields IIUC.
Joerger
force-pushed
the
joerger/is-mfa-required-for-admin-actions
branch
from
c60f31f to
b5e59d0
Compare
Joerger
force-pushed
the
joerger/is-mfa-required-for-admin-actions
branch
from
b5e59d0 to
79097b5
Compare
Joerger
force-pushed
the
joerger/is-mfa-required-for-admin-actions
branch
2 times, most recently
from
9a23446 to
85ce35a
Compare
… web.createAuthenticateChallenge.
Joerger
force-pushed
the
joerger/is-mfa-required-for-admin-actions
branch
from
85ce35a to
bac2198
Compare
rosstimothy
approved these changes
Jan 18, 2024
gzdunek
approved these changes
Jan 19, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from ryanclark
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an admin action target to
IsMFARequired.Also adds
IsMFARequiredfield toweb.createAuthenticateChallengeto mirrorgrpc CreateAuthenticateChallengefunctionality and skip the extra roundtrip.This will be used for admin action MFA inference and reuse - #35185.