[v14] fix: Do not attempt relogin on remote BadParameter errors#36924
Merged
codingllama merged 2 commits intobranch/v14from Feb 1, 2024
Merged
[v14] fix: Do not attempt relogin on remote BadParameter errors#36924codingllama merged 2 commits intobranch/v14from
codingllama merged 2 commits intobranch/v14from
Conversation
* fix: Do not attempt relogin on trace.BadParameterError * Special case remote errors in IsErrorResolvableWithRelogin * Do not wrap Recv EOF errors * Fix various tests * Use errors.Is to check for io.EOF
Contributor
Author
|
Clean backport - git got a bit confused with the assertions on api/utils/grpc/interceptors/errors_test.go but the final patch ended exactly the same. |
This was referenced Jan 19, 2024
Contributor
Author
|
I'll hold merging until the end of v15 testplan, just in case. |
tigrato
approved these changes
Jan 19, 2024
Joerger
approved these changes
Jan 23, 2024
rosstimothy
approved these changes
Jan 30, 2024
Contributor
Author
|
FYI, I'm waiting until #37647 can be backported to merge this one. |
* Verify that intercepted stream Sends wrap io.EOF * fix: Do not wrap io.EOF intercepted by stream Sends * Use a helper func, fix duplicate Send/Recv calls * Fix typo
Contributor
Author
|
I've cherry-picked #37647 on top of this. PTAL. |
Joerger
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36866 and #37647 to branch/v14.
Changelog: Fix tsh trying to relogin on fatal errors
#36749, #36850