Skip to content

[v14] Unblock Read and Write when closing a gRPC transport net.Conn#37351

Closed
espadolini wants to merge 1 commit into
branch/v14from
bot/backport-37343-branch/v14
Closed

[v14] Unblock Read and Write when closing a gRPC transport net.Conn#37351
espadolini wants to merge 1 commit into
branch/v14from
bot/backport-37343-branch/v14

Conversation

@espadolini

Copy link
Copy Markdown
Contributor

Backport #37343 to branch/v14

@espadolini espadolini added backport size/sm no-changelog Indicates that a PR does not require a changelog entry labels Jan 26, 2024
@espadolini espadolini enabled auto-merge January 26, 2024 17:54
@espadolini espadolini force-pushed the bot/backport-37343-branch/v14 branch from 359a322 to 2fdbdfb Compare January 30, 2024 15:43
@espadolini

Copy link
Copy Markdown
Contributor Author

Blocked on #36924

@rosstimothy

Copy link
Copy Markdown
Contributor

Blocked on #36924

Are we good to go now that #36924 has landed in branch/v14?

@espadolini espadolini force-pushed the bot/backport-37343-branch/v14 branch 3 times, most recently from a208ee6 to 95771ea Compare February 2, 2024 14:11
@espadolini

Copy link
Copy Markdown
Contributor Author

The behavior of the net.Conn returned by DialHost is quite surprising, and tests only actually end up working out because of the strange behavior; the tests in branch/v15 and master are currently passing because the connection is actually a resumable connection, which we don't yet have in v14. Since this backport is needed only as part of connection resumption, I'm closing this for now and we'll roll this backport in if we decide to backport connection resumption to v14.

@espadolini espadolini closed this Feb 2, 2024
auto-merge was automatically disabled February 2, 2024 18:34

Pull request was closed

@espadolini espadolini deleted the bot/backport-37343-branch/v14 branch February 2, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants