[v12] Always close completed app sessions#36888
Merged
rosstimothy merged 1 commit intobranch/v12from Jan 19, 2024
Merged
Conversation
The previous use of gravitational/ttlmap with a fixed capacity led to sessions leaking and never being closed if a spike of sessions greater than the capcity occurred. The sessionChunkCache relied on the expiry callback function set on the ttlmap to be called in order to close the app session and release resources. However, if an item was evicted from the ttlmap because the capacity had been exceeded the expiry callback was fired. Instead of increasing the capacity to a larger size the ttlmap was replaced entirely by utils.FnCache. It offers equivalent functionality while still being actively maintained. This also allowed refactoring to remove the sessionChunkCache entirely since the FnCache took care of most of the added functionality that the ttlmap wrapper was providing. Partially addressed #36541.
rosstimothy
force-pushed
the
tross/backport-36651/v12
branch
from
3c6849b to
0164c4d
Compare
tigrato
approved these changes
Jan 18, 2024
zmb3
approved these changes
Jan 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36651 to branch/v12
changelog: Ensure that any opened app session is always closed on completion