integrations/operator: add multi-version support in crdgen#36715
Merged
integrations/operator: add multi-version support in crdgen#36715
Conversation
hugoShaka
added
the
no-changelog
hugoShaka
force-pushed
the
hugo/crdgen-multi-version
branch
from
f6e73d9 to
fbea4f2
Compare
marcoandredinis
approved these changes
Jan 18, 2024
r0mant
approved these changes
Jan 23, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from tigrato
hugoShaka
force-pushed
the
hugo/crdgen-multi-version
branch
4 times, most recently
from
106a1f8 to
538a0ac
Compare
|
@hugoShaka - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
… in crdgen The commit contains the following changes: - add multi-version support by creating new kinds. This is currently done via an override to maintain compatibility. At some point, we might migrate unversioned kinds (TeleportRole) to versioned kinds (TeleportRoleV5) and remove the override - unify all resource statuses in a single struct. This simplifies the CRD building because we are not trying to guess which package is correct anymore when parsing go's AST - update crdgen snapshots This PR does not update the base CRDs in the operator or the Hlem chart. This will happen in the next PR, adding go types and controller support. Note for reviewers: the changeset might seem large, but the changes are split into commits that are much more reviewable. You only need to review the first two commits.
hugoShaka
force-pushed
the
hugo/crdgen-multi-version
branch
from
538a0ac to
2259576
Compare
This was referenced Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 1 of the RFD-0160 implementation. Part of #20261
The PR contains the following changes:
TeleportRole) to versioned kinds (TeleportRoleV5) and remove the overridecrdgensnapshotsNote for reviewers: the changeset might seem large, but the changes are split into commits that are much more reviewable. You only need to review the first two commits.