[v13] fix saml IdP service provider validation#36659
Merged
rosstimothy merged 2 commits intobranch/v13from Jan 18, 2024
Merged
Conversation
github-actions
Bot
requested review from
flyinghermit,
rosstimothy,
xacrimon and
zmb3
rosstimothy
approved these changes
Jan 13, 2024
flyinghermit
approved these changes
Jan 15, 2024
* - FilterSAMLEntityDescriptor only if entity descriptor is not empty. - only issue warning on unsupported acs bindings. * include HTTPArtifactBinding in supported acs bindings * update TestFilterSAMLEntityDescriptor * exclude HTTPArtifactBinding and filter them from generated entity descriptor * remove HTTPArtifactBinding from test entity descriptor
fspmarshall
force-pushed
the
fspmarshall/fix-saml-validation-v13
branch
from
159d3e8 to
f16218c
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36057 and #36602 to branch/v13
changelog: Fixed an issue where valid saml entity descriptors could be rejected.