relax client side entity descriptor validation#36602
Merged
flyinghermit merged 5 commits intomasterfrom Jan 12, 2024
Merged
Conversation
- only issue warning on unsupported acs bindings.
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
flyinghermit
added
the
no-changelog
Contributor
Author
|
no changelog as the original PR is not yet backported to older branch. |
fspmarshall
approved these changes
Jan 12, 2024
greedy52
approved these changes
Jan 12, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from nklaassen
fspmarshall
pushed a commit
that referenced
this pull request
Jan 12, 2024
* - FilterSAMLEntityDescriptor only if entity descriptor is not empty. - only issue warning on unsupported acs bindings. * include HTTPArtifactBinding in supported acs bindings * update TestFilterSAMLEntityDescriptor * exclude HTTPArtifactBinding and filter them from generated entity descriptor * remove HTTPArtifactBinding from test entity descriptor
This was referenced Jan 12, 2024
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
* fix saml validation * relax client side entity descriptor validation (#36602) * - FilterSAMLEntityDescriptor only if entity descriptor is not empty. - only issue warning on unsupported acs bindings. * include HTTPArtifactBinding in supported acs bindings * update TestFilterSAMLEntityDescriptor * exclude HTTPArtifactBinding and filter them from generated entity descriptor * remove HTTPArtifactBinding from test entity descriptor --------- Co-authored-by: Sakshyam Shah <sshah@goteleport.com>
fspmarshall
pushed a commit
that referenced
this pull request
Jan 18, 2024
* - FilterSAMLEntityDescriptor only if entity descriptor is not empty. - only issue warning on unsupported acs bindings. * include HTTPArtifactBinding in supported acs bindings * update TestFilterSAMLEntityDescriptor * exclude HTTPArtifactBinding and filter them from generated entity descriptor * remove HTTPArtifactBinding from test entity descriptor
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
* fix saml validation * relax client side entity descriptor validation (#36602) * - FilterSAMLEntityDescriptor only if entity descriptor is not empty. - only issue warning on unsupported acs bindings. * include HTTPArtifactBinding in supported acs bindings * update TestFilterSAMLEntityDescriptor * exclude HTTPArtifactBinding and filter them from generated entity descriptor * remove HTTPArtifactBinding from test entity descriptor --------- Co-authored-by: Sakshyam Shah <sshah@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FilterSAMLEntityDescriptorerror.FilterSAMLEntityDescriptorto skip issuing warning on quiet operation.HTTPArtifactBindingfrom Teleport generated descriptor as the binding is created by default when entity descriptor is generated using crewjam/saml .closes #36597