[v12] split db ca#36259
Closed
GavinFrazar wants to merge 6 commits intobranch/v12from
Closed
Conversation
Backport #35949 to branch/v12.
Contributor
Author
|
this didnt make the last v12 release cut |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #35949 to branch/v12.
changelog: TODO
leaving in draft for CI and until all of v12,13,14 are up.
There were a lot of merge conflicts for this backport.
I had to fixup rotation requests for DatabaseClientCA and change the filter injection a bit in
lib/auth/grpcserver.go.v12 still had its own filter injection there - I check if that one installs a filter before checking whether we need to install a CA filter that excludes the DatabaseClientCA.
I also removed the code that tries to modify the OpInit event that comes from upstream, since v12 does not have "confirmed kinds" or
WatchStatus, so modifying the OpInit event isn't needed.The major changes from the original PR are split out into subsequent commits after the initial backport commit.