Skip to content

split database CA into server/client CAs#35949

Merged
GavinFrazar merged 3 commits intomasterfrom
gavinfrazar/split-db-ca
Jan 15, 2024
Merged

split database CA into server/client CAs#35949
GavinFrazar merged 3 commits intomasterfrom
gavinfrazar/split-db-ca

Conversation

@GavinFrazar
Copy link
Copy Markdown
Contributor

@GavinFrazar GavinFrazar commented Dec 20, 2023

Fixes https://github.com/gravitational/teleport-private/issues/782

changelog: Introduced the Teleport Database Client CA so that separate CAs are used to issue certs to databases and database clients.

Copy link
Copy Markdown

@orca-security-us orca-security-us Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca
Failed Failed Secrets high 1   medium 0   low 0   info 0 View in Orca

🔑 The following secrets have been detected in your pull request across all commits

⚠️ Please take action to mitigate the risk of the identified secrets by revoking them, and if already in use, updating all dependent systems

NAME FILE PATH LINE NUM COMMIT STATUS
Private Key lib/fixtures/keys.go 64 f23e11996 FAILED View in code

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-6gykc9pyl-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-yk7sbmvhh-goteleport.vercel.app/docs/ver/preview

@GavinFrazar GavinFrazar force-pushed the gavinfrazar/split-db-ca branch from e7cb698 to ddc0734 Compare January 3, 2024 02:07
GavinFrazar added a commit that referenced this pull request Jan 3, 2024
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/split-db-ca branch from ddc0734 to d3f8c5b Compare January 3, 2024 02:40
GavinFrazar added a commit that referenced this pull request Jan 4, 2024
@GavinFrazar GavinFrazar mentioned this pull request Jan 4, 2024
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/split-db-ca branch from d3f8c5b to 1f5a76d Compare January 4, 2024 04:04
GavinFrazar added a commit that referenced this pull request Jan 4, 2024
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/split-db-ca branch from 1f5a76d to 79bd5be Compare January 12, 2024 23:26
@GavinFrazar GavinFrazar marked this pull request as ready for review January 12, 2024 23:27
@github-actions github-actions Bot added database-access Database access related issues and PRs size/lg tctl tctl - Teleport admin tool labels Jan 12, 2024
* update migration logging
    * include auth component in migrations
    * debug log when skipping db client ca migration
* update tctl auth sign for cockroachdb
* update tctl auth sign for oracle
* set ExtKeyUsage for DB certs
    * clientAuth for DB Client CA
    * serverAuth for DB Server CA
* inject filter for pre-v14.3.1 clients
* inject a filter instead of dropping events in grpcserver
* add DatabaseClientCA type
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/split-db-ca branch from 79bd5be to 11f55fd Compare January 12, 2024 23:40
@GavinFrazar GavinFrazar requested review from greedy52 and removed request for camscale and rosstimothy January 12, 2024 23:44
Comment thread lib/auth/grpcserver.go Outdated
@GavinFrazar GavinFrazar enabled auto-merge January 13, 2024 02:17
@GavinFrazar GavinFrazar added this pull request to the merge queue Jan 13, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 13, 2024
@GavinFrazar GavinFrazar added this pull request to the merge queue Jan 14, 2024
Merged via the queue into master with commit 5c568bb Jan 15, 2024
@GavinFrazar GavinFrazar deleted the gavinfrazar/split-db-ca branch January 15, 2024 00:13
@public-teleport-github-review-bot
Copy link
Copy Markdown

@GavinFrazar See the table below for backport results.

Branch Result
branch/v12 Failed
branch/v13 Failed
branch/v14 Failed

GavinFrazar added a commit that referenced this pull request Jan 30, 2024
@GavinFrazar GavinFrazar added the security Security Issues label Feb 21, 2024
GavinFrazar added a commit that referenced this pull request Feb 21, 2024
github-merge-queue Bot pushed a commit that referenced this pull request Feb 21, 2024
* [v14] split database CA into server/client CAs

Backport #35949 to branch/v14.

* fix pkcs12 encoding for backport

* debug log when skipping filter injection

* update CA filter injection version check func name and doc

* update filter injection version checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database-access Database access related issues and PRs security Security Issues size/lg tctl tctl - Teleport admin tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants