fix flaky lib/auth cache-enabled tests#36216
Merged
GavinFrazar merged 3 commits intomasterfrom Jan 3, 2024
Merged
Conversation
GavinFrazar
added
flaky tests
backport/branch/v14
no-changelog
GavinFrazar
changed the title
lib/auth cache-enabled tests
GavinFrazar
added a commit
that referenced
this pull request
Jan 2, 2024
Backport #36216 to branch/v14.
zmb3
reviewed
Jan 3, 2024
fspmarshall
approved these changes
Jan 3, 2024
zmb3
approved these changes
Jan 3, 2024
|
@GavinFrazar See the table below for backport results.
|
Envek
added a commit
to Envek/teleport
that referenced
this pull request
Jan 4, 2024
…se-anon-key * origin/master: (344 commits) Undelete CreateHostUserMode_HOST_USER_MODE_DROP (gravitational#36273) allow cwd to be changed in difftest (gravitational#35946) Auth device list component (gravitational#36235) make unified resources responsive (gravitational#35961) Support running Teleport in a "hot reload" mode (gravitational#35040) Prevent deleting enum values, allow deleting enum reservations in types.proto (gravitational#36248) Remove support for legacy (Amazon Linux 2) AMIs (gravitational#36153) Bump version(s) used for teleport-lab and teleport-quickstart (gravitational#36167) Allow Reconciler update handler to examine old value during update (gravitational#36171) Validate the user still exists during account reset (gravitational#35676) ButtonTextWithAddIcon shared component (gravitational#36103) Refactor hostname resolution for SSH connections via the WebUI (gravitational#35773) add structuredClone to jest JSDOMEnvironment (gravitational#36213) fix flaky `lib/auth` cache-enabled tests (gravitational#36216) Report resource usage counts by handling heartbeat events (gravitational#35968) Reviewer bot should use the stable version of Go (gravitational#36242) RFD 0153 Resource Guidelines (gravitational#34103) Use cmp and cmpots properly in operator tests (gravitational#36215) Relax Kubernetes CRD discovery when building cache (gravitational#36214) Add Access List messages to TAG protobuf (gravitational#36176) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flaky cache-enabled
lib/authtests, namely theTestListUnifiedResources_*tests (those are the only ones with cache enabled).I was debugging an unrelated change locally and noticed sporadic failures in these test cases, for example:
The fix is to start the test auth server's cache after config resources like cluster name are all initialized, the same as we do in lib/service/service.go:initAuthService for the real implementation.
We only enabled cache in these tests since v14 in this PR, so that's as far as I'll backport.