Skip to content

Bump version(s) used for teleport-lab and teleport-quickstart#36167

Merged
reedloden merged 1 commit intomasterfrom
reed/bump-teleport-lab-ver
Jan 4, 2024
Merged

Bump version(s) used for teleport-lab and teleport-quickstart#36167
reedloden merged 1 commit intomasterfrom
reed/bump-teleport-lab-ver

Conversation

@reedloden
Copy link
Copy Markdown
Contributor

The versions for teleport-lab / teleport-quickstart were still using Teleport 12. Bump them to Teleport 14.

The versions for teleport-lab / teleport-quickstart were still using
Teleport 12. Bump them to Teleport 14.
@reedloden reedloden added the no-changelog Indicates that a PR does not require a changelog entry label Jan 1, 2024
@reedloden reedloden self-assigned this Jan 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 1, 2024

🤖 Vercel preview here: https://docs-hh3ks2085-goteleport.vercel.app/docs/ver/preview

Copy link
Copy Markdown
Contributor

@benarent benarent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, we need to test this locally as instructions also need to updated between these versions.

@reedloden
Copy link
Copy Markdown
Contributor Author

Note, we need to test this locally as instructions also need to updated between these versions.

Assume you mean https://github.com/gravitational/instruqt-teleport-lab? I agree that also needs to be updated, but we're not removing the v12 lab images. Just actually generating them for v13 and v14 (which we hadn't been before) and making v14 the default in the docker files. However, the Instruqt labs hardcode v12, so there won't be any change that I can see (please let me know if I am missing something).

Looks like that is still using quay.io/gravitational/teleport-lab:12. Quay.io is fully deprecated and will be getting turned off completely in a few months (see https://github.com/gravitational/teleport/blob/master/CHANGELOG.md#quayio-registry).

@ptgott
Copy link
Copy Markdown
Contributor

ptgott commented Jan 2, 2024

Is this one getting backported?

@benarent
Copy link
Copy Markdown
Contributor

benarent commented Jan 2, 2024

Note, we need to test this locally as instructions also need to updated between these versions.

I thought we still had public docs for this, but we don't, just labs. So we can merge this.

@reedloden
Copy link
Copy Markdown
Contributor Author

Is this one getting backported?

I don't see any reason to. The drone job is master-only.

Copy link
Copy Markdown
Contributor

@camscale camscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://gallery.ecr.aws/gravitational/teleport-lab, the 14 label does not exist for this docker image. I assume that the drone cron job will create it? Should that part get committed first and only once the image exists do we update the images in the dockerfiles? Or do we not care it is out of sync/broken until the cronjob runs?

@reedloden
Copy link
Copy Markdown
Contributor Author

Looking at https://gallery.ecr.aws/gravitational/teleport-lab, the 14 label does not exist for this docker image. I assume that the drone cron job will create it? Should that part get committed first and only once the image exists do we update the images in the dockerfiles? Or do we not care it is out of sync/broken until the cronjob runs?

IMHO, we don't care. It'll get fixed within 24 hours once the cron runs (as it runs daily).

@reedloden reedloden added this pull request to the merge queue Jan 4, 2024
Merged via the queue into master with commit bcd1db9 Jan 4, 2024
@reedloden reedloden deleted the reed/bump-teleport-lab-ver branch January 4, 2024 01:38
Envek added a commit to Envek/teleport that referenced this pull request Jan 4, 2024
…se-anon-key

* origin/master: (344 commits)
  Undelete CreateHostUserMode_HOST_USER_MODE_DROP (gravitational#36273)
  allow cwd to be changed in difftest (gravitational#35946)
  Auth device list component (gravitational#36235)
  make unified resources responsive (gravitational#35961)
  Support running Teleport in a "hot reload" mode (gravitational#35040)
  Prevent deleting enum values, allow deleting enum reservations in types.proto (gravitational#36248)
  Remove support for legacy (Amazon Linux 2) AMIs (gravitational#36153)
  Bump version(s) used for teleport-lab and teleport-quickstart (gravitational#36167)
  Allow Reconciler update handler to examine old value during update (gravitational#36171)
  Validate the user still exists during account reset (gravitational#35676)
  ButtonTextWithAddIcon shared component (gravitational#36103)
  Refactor hostname resolution for SSH connections via the WebUI (gravitational#35773)
  add structuredClone to jest JSDOMEnvironment (gravitational#36213)
  fix flaky `lib/auth` cache-enabled tests (gravitational#36216)
  Report resource usage counts by handling heartbeat events (gravitational#35968)
  Reviewer bot should use the stable version of Go (gravitational#36242)
  RFD 0153 Resource Guidelines (gravitational#34103)
  Use cmp and cmpots properly in operator tests (gravitational#36215)
  Relax Kubernetes CRD discovery when building cache (gravitational#36214)
  Add Access List messages to TAG protobuf (gravitational#36176)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants