[v14] Use the cache for user login state.#36196
Merged
mdwn merged 1 commit intobranch/v14from Jan 3, 2024
Merged
Conversation
It was discovered that the user login state isn't being used for the user login state generator. This means that role lookups are not being cached, which is an unnecessary performance burden, and any potential further cache updates would not be used. This has been fixed.
tigrato
approved these changes
Jan 2, 2024
greedy52
approved these changes
Jan 3, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from kimlisa
Merged
Collaborator
I'm not sure we can expect anyone to understand what this means. The term |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36021 to branch/v14
changelog: The user login state generator now uses the cache, which should reduce the number of calls to the backend.