Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
kimlisa
approved these changes
Dec 23, 2023
Collaborator
|
How about a title of use the cache for user login state? Again, taking the format of: if applied, this commit will ________ |
mdwn
changed the title
greedy52
approved these changes
Jan 2, 2024
It was discovered that the user login state isn't being used for the user login state generator. This means that role lookups are not being cached, which is an unnecessary performance burden, and any potential further cache updates would not be used. This has been fixed.
mdwn
force-pushed
the
mike.wilson/uls-generator-uses-cache
branch
from
6e8d411 to
3f5aa43
Compare
This was referenced Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was discovered that the user login state isn't being used for the user login state generator. This means that role lookups are not being cached, which is an unnecessary performance burden, and any potential further cache updates would not be used. This has been fixed.
changelog: The user login state generator now uses the cache, which should reduce the number of calls to the backend.