[v14] Add support for include_enterprise_slug for the github join method (#35860)#35900
Merged
strideynet merged 1 commit intobranch/v14from Dec 20, 2023
Merged
Conversation
#35860) * Add support for `include_enterprise_slug` in `github` joining * Correct assertiosn in github validator token test * Remove `want` in TestIDTokenValidator_Validate * Fix missing `should` in docs Co-authored-by: Krzysztof Skrzętnicki <krzysztof.skrzetnicki@goteleport.com> * Fix spelling of customize in docs * Update operator CRDs * Regen protos * Apply suggestions from code review Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> * Try both under same header * Try H4 * Remove spurious period * Use bold rather than heading --------- Co-authored-by: Krzysztof Skrzętnicki <krzysztof.skrzetnicki@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
github-actions
Bot
requested review from
Tener,
espadolini,
ptgott and
wadells
ptgott
approved these changes
Dec 19, 2023
wadells
approved these changes
Dec 19, 2023
espadolini
approved these changes
Dec 19, 2023
Tener
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #35860
changelog: Support github joining from Enterprise accounts with include_enterprise_slug enabled.