Add support for include_enterprise_slug for the github join method#35860
Conversation
github-actions
Bot
requested review from
Tener,
ptgott,
r0mant and
ryanclark
|
CC @wadells - as per our discussion today, this is the patch needed for the upcoming work. |
|
🤖 Vercel preview here: https://docs-1cmkaomu5-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-nzklxzfo2-goteleport.vercel.app/docs/ver/preview |
wadells
left a comment
wadells
left a comment
There was a problem hiding this comment.
Enterprise slug says:
/^\ /^\
{ O} { O}
\ / \ /
// //
// //
/ ~----~/
/ : SHIP IT!
| \________)
| /
| \_____
| ^~-_____
\ ^~-_________
| ^~-_
\___________________________________~~____
Did you test at all in the wild, or will our Teleport use case be the first exercise of this code?
Co-authored-by: Krzysztof Skrzętnicki <krzysztof.skrzetnicki@goteleport.com>
Yup, dm'ed you my test repo where I gave this a go 👍 |
|
🤖 Vercel preview here: https://docs-3io0bxz5i-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-g31f9q2rh-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-87jcemjme-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-8q1ax71py-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-49myal3ye-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-4ve8oeg0f-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-doz0opj2m-goteleport.vercel.app/docs/ver/preview |
public-teleport-github-review-bot
Bot
removed request for
r0mant,
ryanclark,
xinding33 and
zmb3
|
🤖 Vercel preview here: https://docs-awnp27zjs-goteleport.vercel.app/docs/ver/preview |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
strideynet
deleted the
strideynet/support-github-enterprise-slug-in-github-join
branch
|
@strideynet See the table below for backport results.
|
#35860) * Add support for `include_enterprise_slug` in `github` joining * Correct assertiosn in github validator token test * Remove `want` in TestIDTokenValidator_Validate * Fix missing `should` in docs Co-authored-by: Krzysztof Skrzętnicki <krzysztof.skrzetnicki@goteleport.com> * Fix spelling of customize in docs * Update operator CRDs * Regen protos * Apply suggestions from code review Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> * Try both under same header * Try H4 * Remove spurious period * Use bold rather than heading --------- Co-authored-by: Krzysztof Skrzętnicki <krzysztof.skrzetnicki@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
#35860) (#35900) * Add support for `include_enterprise_slug` in `github` joining * Correct assertiosn in github validator token test * Remove `want` in TestIDTokenValidator_Validate * Fix missing `should` in docs * Fix spelling of customize in docs * Update operator CRDs * Regen protos * Apply suggestions from code review * Try both under same header * Try H4 * Remove spurious period * Use bold rather than heading --------- Co-authored-by: Krzysztof Skrzętnicki <krzysztof.skrzetnicki@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
5 participants
Closes #22834 - see this ticket for context.
This will enable the use of
githubjoining from actions in the Teleport GitHub Enterprise account which leverages this feature. This allows the dog-fooding efforts to make use of Machine ID & GitHub Actions.changelog: Support
githubjoining from Enterprise accounts withinclude_enterprise_slugenabled.