[v14] Add auto approval flow for servicenow plugin#35658
Merged
EdwardDowling merged 2 commits intobranch/v14from Dec 13, 2023
Merged
[v14] Add auto approval flow for servicenow plugin#35658EdwardDowling merged 2 commits intobranch/v14from
EdwardDowling merged 2 commits intobranch/v14from
Conversation
* Add initial servicenow auto approval * Stop servicenow healthcheck exiting early * Update servicenow plugin tests to handle auto approval flow * Add comment clarifying choice of identifier for servicenow plugin * Fix healthcheck error handling in servicenow plugin * Fix formatting errors * Add more context to logs * Fix logging in servicenow plugin * Update integrations/access/servicenow/config.go Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com> * Remove supurfluous reqId in log * Remove unused sentinal error * Fix imports * Remove unused field * Fix formating * Change servicenow plugin to always post review updates * Refactor servicenow plugin auto approval flow * Update integrations/access/servicenow/app.go Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com> * Add mock for healthcheck endpoint * Add missing check to skip test in OSS version --------- Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com> Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>
EdwardDowling
changed the title
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
EdwardDowling
changed the title
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
marcoandredinis
approved these changes
Dec 12, 2023
hugoShaka
approved these changes
Dec 12, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #33885
changelog: Added auto approval flow to servicenow plugin.