Skip to content

Add auto approval flow for servicenow plugin#33885

Merged
EdwardDowling merged 19 commits intomasterfrom
edwarddowling/auto-approval
Nov 11, 2023
Merged

Add auto approval flow for servicenow plugin#33885
EdwardDowling merged 19 commits intomasterfrom
edwarddowling/auto-approval

Conversation

@EdwardDowling
Copy link
Copy Markdown
Contributor

@EdwardDowling EdwardDowling commented Oct 24, 2023 •
edited
Loading

Adds auto approval flow to servicenow so users with roles that have a 'schedule' annotation set will be checked to see if they are on-call in the specified rota.

PR adds the functionality to the servicenow plugin's implementation of 'app', the pr to actually use the use custom app is here

changelog: Add auto approval flow to servicenow plugin

@EdwardDowling EdwardDowling changed the title Edwarddowling/auto approval Add auto approval flow for servicenow plugin Oct 24, 2023
@EdwardDowling EdwardDowling marked this pull request as ready for review October 25, 2023 15:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 25, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 25, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

hugoShaka
hugoShaka reviewed Oct 26, 2023
View reviewed changes
Comment thread integrations/access/servicenow/app.go Outdated
Comment thread integrations/access/servicenow/client.go Outdated
marcoandredinis
marcoandredinis reviewed Oct 30, 2023
View reviewed changes
Comment thread integrations/access/servicenow/app.go Outdated
Comment thread integrations/access/servicenow/types.go Outdated
Comment thread integrations/access/servicenow/app.go Outdated
Comment thread integrations/access/servicenow/app.go Outdated
Comment thread integrations/access/servicenow/app.go Outdated
Comment thread integrations/access/servicenow/app.go Outdated
Comment thread integrations/access/servicenow/app.go Outdated
@EdwardDowling EdwardDowling force-pushed the edwarddowling/auto-approval branch from 3da88da to 8c87ccd Compare November 2, 2023 15:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

3 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

marcoandredinis
marcoandredinis reviewed Nov 6, 2023
View reviewed changes
Comment thread integrations/access/servicenow/app.go Outdated
Comment thread integrations/access/servicenow/app.go
Comment thread integrations/access/servicenow/config.go Outdated
@EdwardDowling
Copy link
Copy Markdown
Contributor Author

EdwardDowling commented Nov 7, 2023

@hugoShaka Can you take another look at this when you get a chance?

hugoShaka
hugoShaka reviewed Nov 9, 2023
View reviewed changes
Comment thread integrations/access/servicenow/app.go Outdated
hugoShaka
hugoShaka approved these changes Nov 9, 2023
View reviewed changes
Comment thread integrations/access/servicenow/app.go Outdated
@EdwardDowling EdwardDowling force-pushed the edwarddowling/auto-approval branch from 5575271 to e91157e Compare November 10, 2023 16:22
@EdwardDowling EdwardDowling added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@EdwardDowling EdwardDowling added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@EdwardDowling EdwardDowling added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@EdwardDowling EdwardDowling added this pull request to the merge queue Nov 11, 2023
Merged via the queue into master with commit fa5c373 Nov 11, 2023
@EdwardDowling EdwardDowling deleted the edwarddowling/auto-approval branch November 11, 2023 02:08
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Nov 11, 2023

@EdwardDowling See the table below for backport results.

Branch Result
branch/v14 Failed

EdwardDowling added a commit that referenced this pull request Dec 12, 2023
@EdwardDowling @marcoandredinis @hugoShaka
Add auto approval flow for servicenow plugin (#33885)
93ba417 
* Add initial servicenow auto approval

* Stop servicenow healthcheck exiting early

* Update servicenow plugin tests to handle auto approval flow

* Add comment clarifying choice of identifier for servicenow plugin

* Fix healthcheck error handling in servicenow plugin

* Fix formatting errors

* Add more context to logs

* Fix logging in servicenow plugin

* Update integrations/access/servicenow/config.go

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>

* Remove supurfluous reqId in log

* Remove unused sentinal error

* Fix imports

* Remove unused field

* Fix formating

* Change servicenow plugin to always post review updates

* Refactor servicenow plugin auto approval flow

* Update integrations/access/servicenow/app.go

Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>

* Add mock for healthcheck endpoint

* Add missing check to skip test in OSS version

---------

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>
@EdwardDowling EdwardDowling mentioned this pull request Dec 12, 2023
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Dec 13, 2023
@EdwardDowling @marcoandredinis @hugoShaka
Add auto approval flow for servicenow plugin (#33885) (#35658)
502fe6c 
* Add initial servicenow auto approval

* Stop servicenow healthcheck exiting early

* Update servicenow plugin tests to handle auto approval flow

* Add comment clarifying choice of identifier for servicenow plugin

* Fix healthcheck error handling in servicenow plugin

* Fix formatting errors

* Add more context to logs

* Fix logging in servicenow plugin

* Update integrations/access/servicenow/config.go



* Remove supurfluous reqId in log

* Remove unused sentinal error

* Fix imports

* Remove unused field

* Fix formating

* Change servicenow plugin to always post review updates

* Refactor servicenow plugin auto approval flow

* Update integrations/access/servicenow/app.go



* Add mock for healthcheck endpoint

* Add missing check to skip test in OSS version

---------

Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoandredinis marcoandredinis marcoandredinis approved these changes

@hugoShaka hugoShaka hugoShaka approved these changes

Assignees

No one assigned

Labels

size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EdwardDowling @marcoandredinis @hugoShaka