MFA for Admin Actions: auth connectors#35588
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
added
the
no-changelog
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
2 times, most recently
from
bb28377 to
098c2a7
Compare
Joerger
force-pushed
the
joerger/admin-actions-auth-connectors
branch
from
56fac46 to
b0f0e38
Compare
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
from
098c2a7 to
acb9820
Compare
Joerger
force-pushed
the
joerger/admin-actions-auth-connectors
branch
from
b0f0e38 to
41647e2
Compare
rosstimothy
approved these changes
Dec 12, 2023
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
from
acb9820 to
a924514
Compare
EdwardDowling
approved these changes
Dec 13, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from hugoShaka
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
from
a924514 to
49f969f
Compare
Joerger
force-pushed
the
joerger/admin-actions-auth-connectors
branch
from
41647e2 to
db1726e
Compare
Joerger
force-pushed
the
joerger/admin-actions-auth-connectors
branch
from
75a19f7 to
e9addbb
Compare
Joerger
changed the base branch from
master
to
joerger/admin-action-test-suite
auto-merge was automatically disabled
December 16, 2023 00:46
Merge commits are not allowed on this repository
Joerger
force-pushed
the
joerger/admin-actions-auth-connectors
branch
from
97d3c59 to
f287576
Compare
Joerger
force-pushed
the
joerger/admin-action-test-suite
branch
from
8e1ab94 to
2cd717e
Compare
Joerger
force-pushed
the
joerger/admin-actions-auth-connectors
branch
from
f287576 to
06097f6
Compare
Joerger
force-pushed
the
joerger/admin-action-test-suite
branch
from
2cd717e to
9b7909c
Compare
Joerger
force-pushed
the
joerger/admin-actions-auth-connectors
branch
from
06097f6 to
4851733
Compare
Joerger
force-pushed
the
joerger/admin-actions-auth-connectors
branch
from
02e7f9d to
bf5d5c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require MFA for auth connector CRUD.
Part of RFD 131.
Based off #35445 to use the same test helpers.
Note: I tried and failed to add a
tctl sso test, which is the only non-proxy caller ofCreateXXXAuthRequest. I hope to come back to this in a follow up PR to avoid adding it to the manual test plan.