Skip to content

MFA for Admin Actions: roles#35445

Merged
Joerger merged 2 commits intomasterfrom
joerger/admin-actions-roles
Dec 15, 2023
Merged

MFA for Admin Actions: roles#35445
Joerger merged 2 commits intomasterfrom
joerger/admin-actions-roles

Conversation

@Joerger
Copy link
Copy Markdown
Contributor

@Joerger Joerger commented Dec 6, 2023

Require MFA for role CRUD.

Part of RFD 131.

Based off #35386 to use the same test helpers.

@github-actions github-actions Bot added size/md tctl tctl - Teleport admin tool labels Dec 6, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 6, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Dec 6, 2023
@Joerger Joerger force-pushed the joerger/admin-actions-roles branch 2 times, most recently from 1492e91 to bcc8638 Compare December 7, 2023 01:32
@Joerger Joerger changed the base branch from master to joerger/admin-actions-users December 7, 2023 01:33
@Joerger Joerger force-pushed the joerger/admin-actions-users branch from 7e6e922 to 9c67912 Compare December 7, 2023 01:34
@Joerger Joerger force-pushed the joerger/admin-actions-roles branch from bcc8638 to e755932 Compare December 7, 2023 01:34
@Joerger Joerger force-pushed the joerger/admin-actions-users branch from 9c67912 to d59bb0f Compare December 7, 2023 02:31
@Joerger Joerger force-pushed the joerger/admin-actions-roles branch 2 times, most recently from 82f5e88 to 3b0a4e2 Compare December 7, 2023 02:32
@marcoandredinis
Copy link
Copy Markdown
Contributor

When trying to update a role I got the following errors:
image

tsh login --user marco --proxy=127.0.0.1.nip.io:3080
image
When using tctl we can see the prompt text for OTP but there's no wait on stdin

Here's my user configuration
image

I would expect a request for OTP but didn't had one, at least one that I could actually use.

Did I do something wrong? Or it's just not working as expected?

@Joerger Joerger force-pushed the joerger/admin-actions-users branch from d59bb0f to b9a1850 Compare December 7, 2023 21:26
@Joerger
Copy link
Copy Markdown
Contributor Author

Joerger commented Dec 7, 2023

@marcoandredinis It's expected that OTP wouldn't work on the WebUI. This is something I hope to add after the initial v15 release if it can be prioritized.

It should work with tctl though, I'll fix this shortly.

Edit: fixed otp prompt in #35537

@Joerger Joerger force-pushed the joerger/admin-actions-users branch from b9a1850 to d7b206d Compare December 8, 2023 03:06
@Joerger Joerger force-pushed the joerger/admin-actions-roles branch from 3b0a4e2 to 92e7e84 Compare December 8, 2023 03:06
@Joerger Joerger force-pushed the joerger/admin-actions-roles branch from 92e7e84 to f23af78 Compare December 8, 2023 03:37
@Joerger Joerger force-pushed the joerger/admin-actions-users branch 2 times, most recently from 16de23f to 8bccc53 Compare December 12, 2023 00:54
@Joerger Joerger force-pushed the joerger/admin-actions-roles branch 2 times, most recently from bb28377 to 098c2a7 Compare December 12, 2023 01:07
@Joerger Joerger force-pushed the joerger/admin-actions-roles branch from 098c2a7 to acb9820 Compare December 12, 2023 03:10
@Joerger Joerger force-pushed the joerger/admin-actions-users branch from 3884f1f to 9ca0d37 Compare December 12, 2023 18:28
@Joerger Joerger force-pushed the joerger/admin-actions-roles branch from acb9820 to a924514 Compare December 12, 2023 22:00
Base automatically changed from joerger/admin-actions-users to master December 14, 2023 21:59
@Joerger Joerger force-pushed the joerger/admin-actions-roles branch from a924514 to 49f969f Compare December 15, 2023 18:30
@Joerger Joerger enabled auto-merge December 15, 2023 18:30
@Joerger Joerger added this pull request to the merge queue Dec 15, 2023
Merged via the queue into master with commit bda85c2 Dec 15, 2023
@Joerger Joerger deleted the joerger/admin-actions-roles branch December 15, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/md tctl tctl - Teleport admin tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants