[v14] Fill tsh kubectl version with the correct version details#34825
Merged
tigrato merged 1 commit intobranch/v14from Nov 22, 2023
Merged
[v14] Fill tsh kubectl version with the correct version details#34825tigrato merged 1 commit intobranch/v14from
tsh kubectl version with the correct version details#34825tigrato merged 1 commit intobranch/v14from
Conversation
This PR fixes the version reported by `tsh kubectl version` at compile time. Currently, the package reports: `v0.0.0-master+$Format:%H$` The version is derived from the `k8s.io/kubectl` version we import in Teleport main repo where we replace the `v0` with `v1` to follow `kubectl` versions. Unfortunately, k8s.io packages don't expose an api where we can replace the version at runtime (they have something that allows replacing the Git commit but the semantic part must not change). Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
fheinecke
approved these changes
Nov 21, 2023
nklaassen
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #32913 to branch/v14