Fill tsh kubectl version with the correct version details#32913
Merged
Fill tsh kubectl version with the correct version details#32913
tsh kubectl version with the correct version details#32913Conversation
fheinecke
reviewed
Oct 3, 2023
tigrato
force-pushed
the
tigrato/add-kubectl-version
branch
from
97e4734 to
f25b010
Compare
This PR fixes the version reported by `tsh kubectl version` at compile time. Currently, the package reports: `v0.0.0-master+$Format:%H$` The version is derived from the `k8s.io/kubectl` version we import in Teleport main repo where we replace the `v0` with `v1` to follow `kubectl` versions. Unfortunately, k8s.io packages don't expose an api where we can replace the version at runtime (they have something that allows replacing the Git commit but the semantic part must not change). Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/add-kubectl-version
branch
from
f25b010 to
f00be67
Compare
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
nklaassen
approved these changes
Nov 16, 2023
fheinecke
approved these changes
Nov 16, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
This was referenced Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the version reported by
tsh kubectl versionat compile time. Currently, the package reports:v0.0.0-master+$Format:%H$The version is derived from the
k8s.io/kubectlversion we import in Teleport main repo where we replace thev0withv1to followkubectlversions.Unfortunately, k8s.io packages don't expose an api where we can replace the version at runtime (they have something that allows replacing the Git commit but the semantic part must not change).
Depends on https://github.com/gravitational/teleport.e/pull/2554
Changelog: Override the version of
tsh kubectlwith the upstreamkubectlversion used.