Skip to content

[v14] Fixed tag builds using commit instead of tag ref #34675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camscale merged 1 commit into from
Nov 16, 2023
Merged

[v14] Fixed tag builds using commit instead of tag ref #34675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ steps:
- cd "/go/src/github.com/gravitational/teleport/build.assets/tooling"
- 'go run ./cmd/gh-trigger-workflow -owner ${DRONE_REPO_OWNER} -repo teleport.e
-tag-workflow -timeout 30m0s -workflow release-windows.yaml -workflow-ref=${DRONE_BRANCH}
-input oss-teleport-repo=${DRONE_REPO} -input oss-teleport-ref=${DRONE_COMMIT} '
-input oss-teleport-repo=${DRONE_REPO} -input oss-teleport-ref=${DRONE_BRANCH} '
environment:
GHA_APP_KEY:
from_secret: GITHUB_WORKFLOW_APP_PRIVATE_KEY
Expand Down Expand Up @@ -4982,7 +4982,7 @@ steps:
- cd "/go/src/github.com/gravitational/teleport/build.assets/tooling"
- 'go run ./cmd/gh-trigger-workflow -owner ${DRONE_REPO_OWNER} -repo teleport.e
-tag-workflow -timeout 30m0s -workflow release-windows.yaml -workflow-ref=${DRONE_TAG}
-input oss-teleport-repo=${DRONE_REPO} -input oss-teleport-ref=${DRONE_COMMIT} '
-input oss-teleport-repo=${DRONE_REPO} -input oss-teleport-ref=${DRONE_TAG} '
environment:
GHA_APP_KEY:
from_secret: GITHUB_WORKFLOW_APP_PRIVATE_KEY
Expand Down Expand Up @@ -16622,6 +16622,6 @@ image_pull_secrets:
- DOCKERHUB_CREDENTIALS
---
kind: signature
hmac: fd52fd49638234d6e708f49a021e5c2873114d9f5a752c04738685c29f62d9dd
hmac: d34cacc9bae89579ff6fc90d253c055187925256fc8e775619eed5578bce0cc1

...
8 changes: 4 additions & 4 deletions dronegen/windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ import (
)

func ghaWindowsPushPipeline() pipeline {
return getWindowsPipeline(triggerPush, "push", "${DRONE_BRANCH}")
return getWindowsPipeline(triggerPush, "push", "DRONE_BRANCH")
}

func windowsTagPipelineGHA() pipeline {
return getWindowsPipeline(triggerTag, "tag", "${DRONE_TAG}")
return getWindowsPipeline(triggerTag, "tag", "DRONE_TAG")
}

func getWindowsPipeline(pipelineTrigger trigger, triggerName, reference string) pipeline {
Expand All @@ -37,8 +37,8 @@ func getWindowsPipeline(pipelineTrigger trigger, triggerName, reference string)
name: "release-windows.yaml",
timeout: 30 * time.Minute,
slackOnError: true,
srcRefVar: "DRONE_COMMIT",
ref: reference,
srcRefVar: reference,
ref: fmt.Sprintf("${%s}", reference),
shouldTagWorkflow: true,
},
},
Expand Down