[v14] Fixed tag builds using commit instead of tag ref#34675
Merged
camscale merged 1 commit intobranch/v14from Nov 16, 2023
Merged
[v14] Fixed tag builds using commit instead of tag ref#34675camscale merged 1 commit intobranch/v14from
camscale merged 1 commit intobranch/v14from
Conversation
camscale
added
the
no-changelog
camscale
force-pushed
the
camh/v14/fix-windows-signing-tag-build
branch
from
c73ed14 to
260e063
Compare
Tag builds for Windows are broken in the following ways: * The ref used to determine asset version includes a short commit hash (this will cause promotion issues) * Upon retry of a build (or a new tag with the same commit), builds will fail as the old release is not properly cleaned up Changing the reference used to a branch/tag reference should fix the issue for both. Note that the second issue is still bugged for push pipelines, but we almost never retry them so it's not really worth fixing there right now.
camscale
force-pushed
the
camh/v14/fix-windows-signing-tag-build
branch
from
260e063 to
fc4b38c
Compare
rosstimothy
approved these changes
Nov 16, 2023
fheinecke
approved these changes
Nov 16, 2023
public-teleport-github-review-bot
Bot
removed request for
codingllama,
r0mant,
tcsc and
wadells
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag builds for Windows are broken in the following ways:
The ref used to determine asset version includes a short commit hash
(this will cause promotion issues)
Upon retry of a build (or a new tag with the same commit), builds will
fail as the old release is not properly cleaned up
Changing the reference used to a branch/tag reference should fix the
issue for both. Note that the second issue is still bugged for push
pipelines, but we almost never retry them so it's not really worth
fixing there right now.
Backport: #34668