[v12] Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.44.0 to 0.46.0#34560
Closed
jentfoo wants to merge 2 commits intobranch/v12from
Closed
[v12] Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.44.0 to 0.46.0#34560jentfoo wants to merge 2 commits intobranch/v12from
jentfoo wants to merge 2 commits intobranch/v12from
Conversation
…pc/otelgrpc Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.44.0 to 0.46.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.44.0...zpages/v0.46.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…pc/otelgrpc Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.44.0 to 0.46.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.44.0...zpages/v0.46.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
rosstimothy
reviewed
Nov 13, 2023
| github.com/stretchr/testify v1.8.4 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.44.0 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0 | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0 |
Contributor
There was a problem hiding this comment.
When updating otel dependencies we should ensure that all the various dependencies are on the same versions for a particular otel release.
Suggested change
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0 | |
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.0 |
Comment on lines
19
to
21
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.19.0 | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0 | ||
| go.opentelemetry.io/otel/sdk v1.19.0 |
Contributor
There was a problem hiding this comment.
Same comment about keeping otel versions here
Suggested change
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.19.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0 | |
| go.opentelemetry.io/otel/sdk v1.19.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.20.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.20.0 | |
| go.opentelemetry.io/otel/sdk v1.20.0 |
| go.mongodb.org/mongo-driver v1.10.4 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.44.0 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0 | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0 | |
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.0 |
Comment on lines
125
to
128
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.19.0 | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0 | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.19.0 | ||
| go.opentelemetry.io/otel/sdk v1.19.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.19.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.19.0 | |
| go.opentelemetry.io/otel/sdk v1.19.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.20.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.20.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.20.0 | |
| go.opentelemetry.io/otel/sdk v1.20.0 |
Contributor
|
Superseded by #34806 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v12 update of
otelgrpcto address CVE-2023-47108. Examples were updated in #34534