[v14] Machine ID: More rules to gitlab joining and add globby matching to…#34464
Merged
strideynet merged 1 commit intobranch/v14from Nov 13, 2023
Merged
[v14] Machine ID: More rules to gitlab joining and add globby matching to…#34464strideynet merged 1 commit intobranch/v14from
gitlab joining and add globby matching to…#34464strideynet merged 1 commit intobranch/v14from
Conversation
… some fields (#34290) * Add fields for to-be-supported token claims * Modify validation to include new field * Add comparisons for new fields to joining logic * Add support for globby matching for sub, ref, namespace_path and project_path * Document which fields support globby matching * Add tests for join rule engine changes * Regenerate operator CRDs * Add docs for new fields * Correct punctuation in error message Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com> * Correctly use GoDoc-esque comments * Address docs comments * Reuse glob matching code * Correct type of RunnerID field --------- Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
github-actions
Bot
requested review from
hugoShaka,
marcoandredinis and
ptgott
strideynet
changed the title
gitlab joining and add globby matching to…gitlab joining and add globby matching to…
ptgott
approved these changes
Nov 10, 2023
hugoShaka
approved these changes
Nov 10, 2023
zmb3
approved these changes
Nov 11, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from marcoandredinis
marcoandredinis
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #34290